Solve issue 293 about IDENTITY #394
Merged
+42
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
issue293
branch
from
666efc6 to
79056bb
Compare
VincentLanglet
changed the title
|
This is ready to be reviewed @ondrejmirtes (and was simpler than expected finally). Only lowest build are failing, for unrelated reason. |
ondrejmirtes
force-pushed
the
issue293
branch
from
79056bb to
74a186b
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293
I started by adding a failing test
In the expression
IDENTITY(o.subOne), I need to know ifois nullable (or if one of the previous relation is nullable if I made more LEFT-JOIN).I just discovered that a method
isQueryComponentNullablewas provided for this purpose.