-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform test: compare inferred types with real SQL engine results #572
Platform test: compare inferred types with real SQL engine results #572
Conversation
janedbal
commented
May 30, 2024
•
edited
Loading
edited
- This is a needed test before finalization of Autodetect driver setup for precise int/float/bool inference in expressions (stringified or not) #506.
- The intention here is to have real comparison of inferred types with real results for numerous database drivers, PHP versions, configurations and Doctrine versions.
- So far, it only asserts current behaviour and fixes boolean inferring for Postgres, but I think it will gain plenty of improvements once Autodetect driver setup for precise int/float/bool inference in expressions (stringified or not) #506 will be tested by that.
- In order to develop&test locally the same matrix as in CI, I added docker-compose setup copying the CI setup
617b7e2
to
2a597cb
Compare
2a597cb
to
486992b
Compare
2d1adbf
to
5dfa0ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice :)
Two questions:
- Why not cover PHP 7.2+?
- Why not cover PHP 8.2+?
The main point of platform test is to cover different PHP behaviours and that changed only in PHP 8.1. Take this as a starting point, I have a big list of needed improvements of this test. Using complete range of PHP versions can be added. |
Thank you! |