Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform test: compare inferred types with real SQL engine results #572

Merged
merged 8 commits into from
May 31, 2024

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal commented May 30, 2024

@janedbal janedbal force-pushed the matrix-test-real-db-engines branch from 617b7e2 to 2a597cb Compare May 30, 2024 11:56
@janedbal janedbal force-pushed the matrix-test-real-db-engines branch from 2a597cb to 486992b Compare May 30, 2024 11:59
@janedbal janedbal force-pushed the matrix-test-real-db-engines branch from 2d1adbf to 5dfa0ca Compare May 30, 2024 14:55
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice :)

Two questions:

  1. Why not cover PHP 7.2+?
  2. Why not cover PHP 8.2+?

@janedbal
Copy link
Contributor Author

Why not cover PHP 7.2+? Why not cover PHP 8.2+?

The main point of platform test is to cover different PHP behaviours and that changed only in PHP 8.1.


Take this as a starting point, I have a big list of needed improvements of this test. Using complete range of PHP versions can be added.

@ondrejmirtes ondrejmirtes merged commit dd71401 into phpstan:1.4.x May 31, 2024
30 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants