Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong coalesce type inference #583

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal commented Jun 25, 2024

Separated from #506

Coalesce is pretty nasty function:

Therefore, we cannot use the constant types if we do not know the casting logic as it results in wrong types deduced.

@ondrejmirtes ondrejmirtes merged commit 3d10eab into phpstan:1.4.x Jun 25, 2024
36 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants