Skip to content

Test hydration modes #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2024
Merged

Test hydration modes #590

merged 4 commits into from
Jun 28, 2024

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal commented Jun 28, 2024 •
edited
Loading

@janedbal janedbal mentioned this pull request Jun 28, 2024
Closed
@janedbal janedbal force-pushed the hydration-mode-test branch from 690c724 to a2487c9 Compare June 28, 2024 13:13
@janedbal janedbal marked this pull request as ready for review June 28, 2024 13:14
@ondrejmirtes ondrejmirtes merged commit 18ab94d into phpstan:1.4.x Jun 28, 2024
36 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

VincentLanglet
VincentLanglet reviewed Jun 28, 2024
View reviewed changes
tests/Type/Doctrine/Query/QueryResultTypeWalkerHydrationModeTest.php
}

if ($methodName === 'getSingleScalarResult') {
return Query::HYDRATE_SCALAR;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be HYDRATE_SINGLE_SCALAR here @janedbal ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janedbal @ondrejmirtes @VincentLanglet