Skip to content

Added more universal objects #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Added more universal objects #2

merged 1 commit into from
Jan 13, 2017

Conversation

adaamz
Copy link
Contributor

@adaamz adaamz commented Jan 11, 2017

No description provided.

@ondrejmirtes
Copy link
Member

Nette\Security\IIdentity is not a universal object crate
ArrayHash does not need adding because that's already covered by the fact it extends \stdClass.

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nette\Security\IIdentity is not a universal object crate
ArrayHash does not need adding because that's already covered by the fact it extends \stdClass.

@adaamz
Copy link
Contributor Author

adaamz commented Jan 11, 2017

ok, I realized that ArrayHash was random fail and I can't reproduce it again.
What about implementation of IIdentity -> Nette\Security\Identity?
Also I realized that ITemplate is not universal class.

@ondrejmirtes
Copy link
Member

Can you squash the second commit into the first one? Also I'd leave ITemplate in, not because it's a universal object crate, but because it's typehinted as such in Control::getTemplate().

@adaamz
Copy link
Contributor Author

adaamz commented Jan 12, 2017

Yes, that was the initial reason why I added that.
I will squash it together after I add back the ITemplate.

@adaamz
Copy link
Contributor Author

adaamz commented Jan 12, 2017

@ondrejmirtes Check now :-)

@ondrejmirtes ondrejmirtes merged commit 8b0a453 into phpstan:master Jan 13, 2017
@ondrejmirtes
Copy link
Member

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants