Fix setting offset to a List #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Sep 1, 2024
| assertType('true', array_is_list($array)); | ||
|
|
||
| $array[$key] = false; | ||
| assertType('true', array_is_list($array)); |
There was a problem hiding this comment.
Prior to this PR, it was considered as false.
ondrejmirtes
requested changes
Sep 1, 2024
Sorry for the misunderstanding, it should be better now (?) |
ondrejmirtes
requested changes
Sep 1, 2024
| $builder->setOffsetValueType(new ConstantIntegerType(2), new NullType()); | ||
| $this->assertTrue($builder->isList()); | ||
|
|
||
| $oneOrZero = TypeCombinator::union( |
There was a problem hiding this comment.
Please also write some counter-example test as well. Like when we're setting a union offset that does not exist yet, that will make the array be no longer a list. Thanks.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3381