Fix array_is_list call after unset #3400
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3381
It may be surprising but the code
display
TRUE
.As shown in the example https://3v4l.org/0HFeL
So I updated
ConstantArrayType::unsetOffsetType()
and
ConstantArrayTypeBuilder::setOffsetValueType()
Edit: But I feel like this bugfix might not enough like shown by the latest added test 61b6160
=> See https://3v4l.org/XX2fU for the PHP behavior.
So maybe the fix should be done differently