Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableErrorFormatter: improve formatting of error tips #3821

Open
wants to merge 3 commits into
base: 2.1.x
Choose a base branch
from

Conversation

FeBe95
Copy link

@FeBe95 FeBe95 commented Feb 12, 2025

This PR adds some small improvements to the error output, when using the "table" error formatter:

  1. Align tip text after 💡 emoji
  2. Trim trailing new-line of multi-line tips
Before After
 ------ ----------------------------
  Line   FooBar.php
 ------ ----------------------------
  36     I am an error message.
         🪪  foobar.buz
         💡 I am an error tip.
         💡 I span multiple lines.

         ✏️  FooBar.php
  40     I am an error message.
         🪪  foobar.buz
         💡 I am an error tip.
         💡 I span multiple lines.

         ✏️  FooBar.php
 ------ ----------------------------
 ------ ----------------------------
  Line   FooBar.php
 ------ ----------------------------
  36     I am an error message.
         🪪  foobar.buz
         💡  I am an error tip.
         💡  I span multiple lines.
         ✏️  FooBar.php
  40     I am an error message.
         🪪  foobar.buz
         💡  I am an error tip.
         💡  I span multiple lines.
         ✏️  FooBar.php
 ------ ----------------------------


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant