Detect accessing static property as non static

[jnoordsij]

Closes phpstan/phpstan#12692

Thanks to the pointers provided on the issue, I've managed to copy over some bits from the 'reverse' check and adjust them accordingly:

phpstan-src/src/Rules/Properties/AccessStaticPropertiesRule.php

Lines 213 to 228 in 8d4796d

	if (!$property->isStatic()) {
	$hasPropertyTypes = TypeUtils::getHasPropertyTypes($classType);
	foreach ($hasPropertyTypes as $hasPropertyType) {
	if ($hasPropertyType->getPropertyName() === $name) {
	return [];
	}
	}
	return array_merge($messages, [
	RuleErrorBuilder::message(sprintf(
	'Static access to instance property %s::$%s.',
	$property->getDeclaringClass()->getDisplayName(),
	$name,
	))->identifier('property.staticAccess')->build(),
	]);
	}

This seems to work fine, but maybe there's still some configuration to be accounted for, given that while incorrect static access will result in a fatal error, incorrect non static access will only emit an info + warning message. As a consequence maybe this check should be considered less critical/important.

[ondrejmirtes]

Please do not re-number test lines like that. Put the new test at the bottom of the file. Or even better - add a completely new test method with a completely new test file. It can be testBug12692 / bug-12692.php. Thanks

[ondrejmirtes]

Thank you!