Fix DateTime::format('u') return type #3919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Apr 5, 2025
| @@ -76,7 +76,7 @@ public function buildReturnTypeFromFormat(string $formatString, bool $useMicrose | |||
| return $this->buildNumericRangeType(0, 1, false); | |||
| case 'u': | |||
| return $useMicrosec | |||
| ? new IntersectionType([new StringType(), new AccessoryNonFalsyStringType()]) | |||
| ? new IntersectionType([new StringType(), new AccessoryNumericStringType()]) | |||
There was a problem hiding this comment.
Please keep the non-falsy type as well. Also, you could add type inference for v.
mvorisek
force-pushed
the
dt_micros
branch
2 times, most recently
from
cff8270 to
23515db
Compare
|
This pull request has been marked as ready for review. |
|
Thank you. |
This was referenced May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2888 and https://phpstan.org/r/251087ce-9f59-4c2b-853b-b7d0c91cc584