Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matches[0] type for regexes containing "\K" #3920

Open
wants to merge 4 commits into
base: 2.1.x
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Apr 5, 2025

@mvorisek mvorisek marked this pull request as ready for review April 5, 2025 21:43
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@mvorisek mvorisek force-pushed the fix_12792_pcre_k_escape branch from 6744beb to 9c59260 Compare April 5, 2025 21:45
Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mvorisek mvorisek force-pushed the fix_12792_pcre_k_escape branch from 9c59260 to ad0e58a Compare April 6, 2025 09:16
@mvorisek mvorisek force-pushed the fix_12792_pcre_k_escape branch from ad0e58a to 0c22260 Compare April 8, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\K must reset matches, false positives since v2.1.11
3 participants