Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationExtensions: allow custom deprecation-marking logic #3932

Merged
merged 15 commits into from
Apr 14, 2025

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal changed the title DeprecationProviders: allow custom deprecation-marking logic DeprecationExtensions: allow custom deprecation-marking logic Apr 14, 2025
@janedbal janedbal requested a review from ondrejmirtes April 14, 2025 07:38
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeprecationProvider $deprecationResolver is in a bunch of places. So is it provider or resolver? 😊 Please sync the type and the parameter name.

@janedbal janedbal requested a review from ondrejmirtes April 14, 2025 10:37
@ondrejmirtes ondrejmirtes merged commit 752d229 into phpstan:2.1.x Apr 14, 2025
416 of 417 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants