Fix MixedType->equals(ErrorType) #3934
Open
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Apr 14, 2025
| @@ -314,6 +314,10 @@ public function equals(Type $type): bool | |||
| return false; | |||
| } | |||
|
|
|||
| if ($type instanceof ErrorType) { | |||
There was a problem hiding this comment.
MixedType isn't equal to TemplateMixedType.
A bunch of types use !$type instanceof static, maybe we should do it in more cases.
There was a problem hiding this comment.
changing MixedType->equals() to return false for TemplateMixedType makes this test fail.
1) PHPStan\Generics\TemplateTypeFactoryTest::testCreate with data set #6 (PHPStan\Type\Generic\TemplateMixedType Object (...), PHPStan\Type\MixedType Object (...))
mixed -> equals(U (function a(), parameter))
Failed asserting that false is true.
I am not into generics enough to oversee how this should work
|
👍 I suppose this improves the weird cases I had before too, where error is accepted as a mixed or at least something like that 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #3933 (comment)