Ensure MacOS support by tests #50
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Test building extension | |
| on: | |
| pull_request: | |
| branches: | |
| - php8 | |
| push: | |
| branches: | |
| - php8 | |
| permissions: | |
| contents: read | |
| jobs: | |
| self-built-v8-cache-warmup: | |
| strategy: | |
| # set in accordance with number of v8-versions, so caching can kick in properly | |
| max-parallel: 2 | |
| matrix: | |
| operating-system: # &self-built-v8-operating-systems | |
| - ubuntu-latest | |
| # - windows-latest | |
| - macos-latest | |
| v8-versions: # &self-built-v8-v8-versions | |
| - 10.9.194 | |
| # - 11.9.172 | |
| - 12.9.203 | |
| - 13.5.212 | |
| runs-on: ${{ matrix.operating-system }} | |
| steps: | |
| - name: Prepare cache folder v8 ${{ matrix.v8-versions }} | |
| run: | | |
| sudo mkdir -p /opt/v8/self-built/{lib,include} | |
| sudo chown -R $(id -u):$(id -g) /opt/v8/self-built | |
| - name: Restore cache v8 ${{ matrix.v8-versions }} build | |
| id: v8-build-cache | |
| uses: actions/cache/restore@v4 | |
| with: | |
| path: /opt/v8/self-built | |
| key: ${{ runner.os }}-${{ matrix.v8-versions }}-v8-build | |
| - name: Setup Google depot tools | |
| # only needed, when v8 needs to be built | |
| if: steps.v8-build-cache.outputs.cache-hit != 'true' | |
| uses: newkdev/[email protected] | |
| - name: Set up Clang | |
| if: ${{ matrix.operating-system == 'ubuntu-latest' }} | |
| run: | | |
| sudo apt update | |
| sudo apt install -y clang-19 lld-19 | |
| sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100 | |
| sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100 | |
| - name: Build v8 ${{ matrix.v8-versions }} | |
| if: steps.v8-build-cache.outputs.cache-hit != 'true' | |
| run: | | |
| # Store extra tools somewhere undisturbing | |
| set -x | |
| cd "$(mktemp -d)" | |
| ARCH=$(uname -m) | |
| if [[ "$ARCH" == "x86_64" ]]; then | |
| V8CONFIG="x64.release" | |
| ARCH_SHORT="x64" | |
| elif [[ "$ARCH" == "arm64" ]]; then | |
| V8CONFIG="arm64.release" | |
| ARCH_SHORT="arm64" | |
| else | |
| echo "Unknown architecture: $ARCH" >&2 | |
| exit 1 | |
| fi | |
| fetch --nohooks --no-history v8 | |
| cd v8 | |
| git fetch --tag origin refs/tags/${{ matrix.v8-versions }} 1>&2 > /dev/null | |
| git checkout ${{ matrix.v8-versions }} 1>&2 > /dev/null | |
| gclient sync -D 1>&2 > /dev/null | |
| # Setup GN | |
| # Warnings are no errors - @see https://issues.chromium.org/issues/42203398#comment9 | |
| if [[ "${{ runner.os }}" == "macOS" ]]; then | |
| # Run gn gen with args as v8gen does not override target_cpu properly | |
| gn gen out.gn/$V8CONFIG --args='target_cpu="'$ARCH_SHORT'" v8_target_cpu="'$ARCH_SHORT'" is_component_build=true use_custom_libcxx=true treat_warnings_as_errors=false' | |
| else | |
| tools/dev/v8gen.py -vv $V8CONFIG -- is_component_build=true use_custom_libcxx=true treat_warnings_as_errors=false | |
| fi | |
| # Build | |
| ninja -C out.gn/$V8CONFIG/ | |
| if [[ "${{ runner.os }}" == "macOS" ]]; then | |
| LIB_EXT=dylib | |
| else | |
| LIB_EXT=so | |
| fi | |
| # Copy all V8 libraries and support files | |
| cp -v out.gn/$V8CONFIG/lib*.${LIB_EXT}* out.gn/$V8CONFIG/*_blob.bin out.gn/$V8CONFIG/icudtl.dat /opt/v8/self-built/lib/ | |
| # Copy all V8 static libraries as well | |
| cp -v out.gn/$V8CONFIG/obj/libv8_*.a /opt/v8/self-built/lib/ 2>/dev/null || true | |
| # Copy headers | |
| cp -R include/* /opt/v8/self-built/include/ | |
| # Create symlinks for libraries without version numbers | |
| cd /opt/v8/self-built/lib/ | |
| for lib in lib*.${LIB_EXT}.*; do | |
| if [[ $lib == *\.${LIB_EXT}.* ]]; then | |
| ln -sf $lib ${lib%%.*} 2>/dev/null || true | |
| fi | |
| done | |
| # Set library search path | |
| if [[ "${{ runner.os }}" == "Linux" ]]; then | |
| echo "/opt/v8/self-built/lib" | sudo tee /etc/ld.so.conf.d/v8.conf | |
| sudo ldconfig | |
| elif [[ "${{ runner.os }}" == "macOS" ]]; then | |
| # On macOS, update DYLD_LIBRARY_PATH for the current session | |
| echo "DYLD_LIBRARY_PATH=/opt/v8/self-built/lib" >> $GITHUB_ENV | |
| # Also create symlinks in /usr/local/lib for system-wide access | |
| sudo mkdir -p /usr/local/lib/v8 | |
| sudo ln -sf /opt/v8/self-built/lib/*.dylib* /usr/local/lib/v8/ | |
| fi | |
| # Go back to origin | |
| cd "${GITHUB_WORKSPACE}" | |
| - name: Save v8 ${{ matrix.v8-versions }} build cache | |
| if: steps.v8-build-cache.outputs.cache-hit != 'true' | |
| uses: actions/cache/save@v4 | |
| with: | |
| path: /opt/v8/self-built | |
| key: ${{ steps.v8-build-cache.outputs.cache-primary-key }} | |
| self-built-v8: | |
| needs: self-built-v8-cache-warmup | |
| strategy: | |
| matrix: | |
| operating-system: # *self-built-v8-operating-systems | |
| - ubuntu-latest | |
| # - windows-latest | |
| - macos-latest | |
| v8-versions: # *self-built-v8-v8-versions | |
| - 10.9.194 | |
| # - 11.9.172 | |
| - 12.9.203 | |
| - 13.5.212 | |
| php-versions: | |
| # - '8.1' | |
| - '8.2' | |
| - '8.3' | |
| - '8.4' | |
| runs-on: ${{ matrix.operating-system }} | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v2 | |
| - name: Setup PHP | |
| uses: shivammathur/setup-php@v2 | |
| with: | |
| php-version: ${{ matrix.php-versions }} | |
| coverage: none | |
| - name: Set up Clang | |
| if: ${{ matrix.operating-system == 'ubuntu-latest' }} | |
| run: | | |
| sudo apt update | |
| sudo apt install -y clang-19 lld-19 | |
| sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100 | |
| sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100 | |
| - name: Download cache v8 ${{ matrix.v8-versions }} build | |
| uses: actions/cache/restore@v4 | |
| with: | |
| path: /opt/v8/self-built | |
| key: ${{ runner.os }}-${{ matrix.v8-versions }}-v8-build | |
| - name: Build extension | |
| run: | | |
| # Set library paths based on OS | |
| if [[ "${{ runner.os }}" == "Linux" ]]; then | |
| export LD_LIBRARY_PATH="/opt/v8/self-built/lib:${LD_LIBRARY_PATH:-}" | |
| # Ensure linker can find the libraries | |
| echo "/opt/v8/self-built/lib" | sudo tee /etc/ld.so.conf.d/v8js.conf | |
| sudo ldconfig | |
| echo "=== Library search paths ===" | |
| ldconfig -p | grep v8 || true | |
| elif [[ "${{ runner.os }}" == "macOS" ]]; then | |
| export DYLD_LIBRARY_PATH="/opt/v8/self-built/lib:${DYLD_LIBRARY_PATH:-}" | |
| fi | |
| # List V8 libraries for debugging | |
| echo "=== Available V8 libraries ===" | |
| ls -la /opt/v8/self-built/lib/ | |
| # Build the extension | |
| phpize | |
| # Configure with explicit library paths | |
| echo "=== Running configure ===" | |
| ./configure \ | |
| --with-v8js=/opt/v8/self-built \ | |
| LDFLAGS="-L/opt/v8/self-built/lib -Wl,-rpath=/opt/v8/self-built/lib" \ | |
| CPPFLAGS="-I/opt/v8/self-built/include -DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX" \ | |
| LIBS="-lstdc++" \ | |
| V8_LIBS="-L/opt/v8/self-built/lib -lv8 -lv8_libplatform -lv8_libbase -lstdc++ -lpthread -ldl" | |
| # Build with verbose output | |
| echo "=== Building extension ===" | |
| make -j$(nproc) V=1 | |
| # Verify the linked libraries | |
| if [[ "${{ runner.os }}" == "Linux" ]]; then | |
| echo "=== Checking linked libraries ===" | |
| ldd modules/v8js.so | grep -i v8 || true | |
| fi | |
| # Run tests | |
| echo "=== Running tests ===" | |
| make test | |
| - name: Archive test results | |
| if: failure() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: phpt-test-results-on-${{ runner.os }}-${{ matrix.v8-versions }}-${{ matrix.php-versions }} | |
| path: | | |
| php_test_results*.txt | |
| tests/*.out | |
| alpine-package-manager-apk: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v2 | |
| - name: Setup latest Alpine Linux | |
| uses: jirutka/setup-alpine@v1 | |
| - name: Install dependencies | |
| run: | | |
| cat /etc/alpine-release | |
| apk add php83-dev nodejs-dev g++ make | |
| shell: alpine.sh --root {0} | |
| - name: Build extension | |
| run: | | |
| phpize | |
| ./configure | |
| make | |
| make test | |
| shell: alpine.sh {0} | |
| - name: Archive test results | |
| if: failure() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: phpt-test-results-on-alpine | |
| path: | | |
| php_test_results*.txt | |
| tests/*.out | |
| macos-package-manager-brew: | |
| strategy: | |
| matrix: | |
| php-versions: | |
| - '8.2' | |
| - '8.3' | |
| - '8.4' | |
| runs-on: macos-latest | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v2 | |
| - name: Setup PHP | |
| uses: shivammathur/setup-php@v2 | |
| with: | |
| php-version: ${{ matrix.php-versions }} | |
| coverage: none | |
| - name: Set up Homebrew | |
| uses: Homebrew/actions/setup-homebrew@master | |
| - name: Install dependencies | |
| run: | | |
| brew install v8 | |
| # Symlink icudtl.dat to the default location | |
| ln -sf /opt/homebrew/Cellar/v8/$(brew list --versions v8 | awk '{print $2}')/libexec/icudtl.dat /opt/homebrew/lib/icudtl.dat | |
| - name: Build extension | |
| run: | | |
| phpize | |
| ./configure --with-v8js=/opt/homebrew CPPFLAGS="-DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX" | |
| make | |
| make test | |
| - name: Archive test results | |
| if: failure() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: phpt-test-results-on-macos-brew-${{ matrix.php-versions }} | |
| path: | | |
| php_test_results*.txt | |
| tests/*.out |