-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing engines Field Update for Node.js Version Support in v2.0.0 #64
Comments
Yeah we can do this. We decided to add it as a minor in a few other packages because it was missed in the initial release. While it is technically a breaking change, it's omission was an oversight and so aligns with the policy we have set. |
There already is PR #59 for this change. |
Oh cool, I forgot about that one. Lets close this then and use that for any further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi
finalhandler
maintainers,I noticed in the changelog for the latest release (v2.0.0) that there is a breaking change which states:
However, it seems that the
package.json
engines
field was not updated to reflect this change.Would it be possible to update the
engines
field inpackage.json
to explicitly specify the range of supported Node.js versions? This would greatly help in ensuring compatibility when upgrading tofinalhandler
v2.0.0.Thank you for all your hard work on this project!
The text was updated successfully, but these errors were encountered: