Fix: GRPCIndex.query future result type #500
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing a parse_query_response call, causing the result to be the raw Message.
Problem
GRPCIndex.query
was returning a rawMessage
when usingasync_req
. This change fixes that.Solution
Set a result_transformer on the future to parse it.
Type of Change
This is somewhat breaking because anyone affected was likely working around it.
Test Plan
Unclear, the current strategy for testing query doesn't actually generate a response.