br: Pre-alloc all table ids for restore #60343

RidRisR · 2025-03-31T08:29:10Z

What problem does this PR solve?

Issue Number: close #60345 60345

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-03-31T08:29:27Z

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-03-31T08:55:45Z

Codecov Report

Attention: Patch coverage is 60.22727% with 35 lines in your changes missing coverage. Please review.

Project coverage is 74.9536%. Comparing base (2d42a5b) to head (e68ba7e).
Report is 21 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #60343        +/-   ##
================================================
+ Coverage   73.1303%   74.9536%   +1.8232%     
================================================
  Files          1714       1730        +16     
  Lines        474014     482872      +8858     
================================================
+ Hits         346648     361930     +15282     
+ Misses       106037      98931      -7106     
- Partials      21329      22011       +682

Flag	Coverage Δ
integration	`46.7876% <56.8181%> (?)`
unit	`72.4590% <60.2272%> (+0.1019%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6553% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.2452% <62.5000%> (+15.0195%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RidRisR · 2025-04-01T03:03:11Z

/test

ti-chi-bot · 2025-04-01T03:03:14Z

@RidRisR: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-scan-deps

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_br_integration_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR · 2025-04-01T03:03:33Z

/test unit-test

tiprow · 2025-04-01T03:03:33Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-04-01T03:03:36Z

@ti-chi-bot[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

@RidRisR: The /test command needs one or more targets.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-scan-deps
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR · 2025-04-01T03:03:41Z

/test check-dev2

tiprow · 2025-04-01T03:03:54Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR · 2025-04-01T03:04:00Z

/test pull-br-integration-test

tiprow · 2025-04-01T03:04:02Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-04-01T03:04:21Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR · 2025-04-01T09:20:39Z

/test mysql-test

tiprow · 2025-04-01T09:21:01Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Tristan1900

thanks for the change! left a couple of comments

br/pkg/restore/internal/prealloc_table_id/alloc.go

RidRisR · 2025-04-02T04:28:06Z

/test mysql-test

RidRisR · 2025-04-02T04:28:11Z

/test build

RidRisR · 2025-04-02T04:28:16Z

/test check-dev2

tiprow · 2025-04-02T04:28:27Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-04-02T04:28:32Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-04-02T04:28:38Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR · 2025-04-02T07:20:32Z

/test build

tiprow · 2025-04-02T07:20:54Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RidRisR · 2025-04-10T08:40:47Z

/test all

tiprow · 2025-04-10T08:41:13Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Leavrth · 2025-04-10T07:26:17Z

br/pkg/restore/internal/prealloc_table_id/alloc.go

 				}
 			}
 		}
 	}
+	if maxID+count+1 > InsaneTableIDThreshold {
+		return nil


BR will panic if just returns nil.

Tristan1900

thanks for the change and addressing comments, lgtm

ti-chi-bot · 2025-04-10T17:40:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, Tristan1900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Leavrth]
~~br/OWNERS~~ [Leavrth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-04-10T17:40:30Z

[LGTM Timeline notifier]

Timeline:

2025-04-10 09:08:42.992420659 +0000 UTC m=+2333816.676656754: ☑️ agreed by Leavrth.
2025-04-10 17:40:30.26949156 +0000 UTC m=+2364523.953727641: ☑️ agreed by Tristan1900.

RidRisR · 2025-04-11T06:47:47Z

/test unit-test

tiprow · 2025-04-11T06:48:09Z

@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-04-11T08:23:51Z

@RidRisR: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev_2	`e68ba7e`	link	unknown	`/test check-dev2`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 31, 2025

ti-chi-bot bot removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Mar 31, 2025

Tristan1900 reviewed Apr 1, 2025

View reviewed changes

br/pkg/restore/internal/prealloc_table_id/alloc.go Outdated Show resolved Hide resolved

br/pkg/restore/internal/prealloc_table_id/alloc.go Outdated Show resolved Hide resolved

br/pkg/restore/internal/prealloc_table_id/alloc.go Outdated Show resolved Hide resolved

RidRisR requested a review from Tristan1900 April 2, 2025 03:47

RidRisR added 16 commits April 9, 2025 09:57

mod db test

17959c5

make bazel

82a4d17

fix tests

b9e7408

fix create table

e204430

lint

23bac5e

fix ut

5858ac9

fix more ut

c892b31

fix ut *2

ef173ad

fix ut*3

7a8e67b

fix comment

f6bb5ff

delay clone table info

049b580

fix comment

1b3bed3

new alloc

b1e3ed0

fix comment

9f1e1ec

lint

3cf6d4b

remove sort

e68ba7e

RidRisR force-pushed the alloc branch from 7bdd533 to e68ba7e Compare April 9, 2025 07:59

Leavrth approved these changes Apr 10, 2025

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2025

Tristan1900 approved these changes Apr 10, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

br: Pre-alloc all table ids for restore #60343

br: Pre-alloc all table ids for restore #60343

RidRisR commented Mar 31, 2025 •

edited

Loading

tiprow bot commented Mar 31, 2025

codecov bot commented Mar 31, 2025 •

edited

Loading

RidRisR commented Apr 1, 2025

ti-chi-bot bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

Tristan1900 left a comment

RidRisR commented Apr 2, 2025

RidRisR commented Apr 2, 2025

RidRisR commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

RidRisR commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

RidRisR commented Apr 10, 2025

tiprow bot commented Apr 10, 2025

Leavrth Apr 10, 2025

Tristan1900 left a comment

ti-chi-bot bot commented Apr 10, 2025

ti-chi-bot bot commented Apr 10, 2025

RidRisR commented Apr 11, 2025

tiprow bot commented Apr 11, 2025

ti-chi-bot bot commented Apr 11, 2025

br: Pre-alloc all table ids for restore #60343

Are you sure you want to change the base?

br: Pre-alloc all table ids for restore #60343

Conversation

RidRisR commented Mar 31, 2025 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Mar 31, 2025

codecov bot commented Mar 31, 2025 • edited Loading

Codecov Report

RidRisR commented Apr 1, 2025

ti-chi-bot bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

RidRisR commented Apr 1, 2025

tiprow bot commented Apr 1, 2025

Tristan1900 left a comment

Choose a reason for hiding this comment

RidRisR commented Apr 2, 2025

RidRisR commented Apr 2, 2025

RidRisR commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

RidRisR commented Apr 2, 2025

tiprow bot commented Apr 2, 2025

RidRisR commented Apr 10, 2025

tiprow bot commented Apr 10, 2025

Leavrth Apr 10, 2025

Choose a reason for hiding this comment

Tristan1900 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Apr 10, 2025

ti-chi-bot bot commented Apr 10, 2025

[LGTM Timeline notifier]

RidRisR commented Apr 11, 2025

tiprow bot commented Apr 11, 2025

ti-chi-bot bot commented Apr 11, 2025

RidRisR commented Mar 31, 2025 •

edited

Loading

codecov bot commented Mar 31, 2025 •

edited

Loading