ddl: Non clustered reorg part optimistic backfill #60382
Conversation
…part-backfill-dml-58226
TODO: Still check issues with new _tidb_rowid's when it comes to INDEX as well as updating both new+old set of partition as well as old+new...
…g-duplicate-_tidb_rowid-fix
ti-chi-bot
bot
added
do-not-merge/invalid-title
release-note
|
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mjonss
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60382 +/- ##
================================================
+ Coverage 73.0980% 74.8644% +1.7664%
================================================
Files 1714 1760 +46
Lines 474475 482791 +8316
================================================
+ Hits 346832 361439 +14607
+ Misses 106307 98551 -7756
- Partials 21336 22801 +1465
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…g-duplicate-_tidb_rowid-fix
…-clustered-reorg-part-optimistic-backfill
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…g-part-optimistic-backfill
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #60381
Problem Summary:
To be fully consistent during backfill of reorganize partition, we check every row by trying to read the rows before writing them, to avoid overwriting. This read can be skipped if we set the
PresumeKeyNotExistsflag insteadWhat changed and how does it work?
Do one try with
PresumeKeyNotExistsand if failing, fallback to current implementation.Build upon #60132.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.