-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use Create react app instead of custom webpack. #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for suggestion @quantuminformation. |
I am trying to move my Typescrit project (one I created from React Boilerplate) to Create React App but the problem is CRA uses Babel Typescript transpiler and it has no support for Typescript namespaces ! It's a big problem when you use Swagger Codegen to generate API clients and you use enums in your Swagger file since enums are defined in namespaces. I had the same problem with a React Native project and had to bypass Babel TS transpiler. One solution may be to eject React Scripts and replace babel-loader in webpack config file with awesome-typescript-loader for example. But I had not tested it yet. Obviously the best solution would be to change the way Swagger Codegen works with enums. But it looks a bit complex ! |
I probably found a better solution : using Open API generators to generate my API client from Swagger, since they don't use namespaces. I am giving it a try ! And moreover the generated code is cleaner. |
I'm willing to fund this issue. |
I think this issue will allow the patterns expressed here to fit in easier to other CRA apps based on my efforts this week. |
My card keeps getting declined by stipe( The credit card form is pretty bad for that stripe widget. |
@IssueHunt has funded $150.00 to this issue.
|
I'll be working on this today |
Top man
On Sat, 13 Apr 2019 at 10:25, Piotrek Witek ***@***.***> wrote:
I'll be working on this today
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANN9gWFDzhZcwHIc0ZveM9BkJQe5Km9ks5vgZSRgaJpZM4cLL2Y>
.
--
Kind regards
Nikos Katsikanis
|
@piotrwitek has rewarded $105.00 to @piotrwitek. See it on IssueHunt
|
Nice work! |
Now that Create react app has typescript support, I would suggest using that, to make this project fit closer to real-world projects. All of my clients use Create react app for typescript.
The text was updated successfully, but these errors were encountered: