Skip to content

Create a package for overwritten tslint.json configurations #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdsedmundo opened this issue Apr 16, 2018 · 8 comments · Fixed by #156
Closed

Create a package for overwritten tslint.json configurations #69

rdsedmundo opened this issue Apr 16, 2018 · 8 comments · Fixed by #156

Comments

@rdsedmundo
Copy link

Why not have a package that could be downloaded from NPM containing those rules overwrites. It's bad having to duplicate them across all the repositories.

I'd like to just yarn add tslint-react-redux-typescript-guide then use extends: tslint-react-redux-typescript-guide.

@piotrwitek
Copy link
Owner

Hi,
That's interesting suggestion, I'll definitely think about that 👍

@IssueHuntBot
Copy link

@BoostIO funded this issue with $15. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@loadbalance-sudachi-kun funded this issue with $256. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@piotrwitek has started working. Visit this issue on Issuehunt

@piotrwitek
Copy link
Owner

piotrwitek commented Sep 17, 2018

Already create a npm package: https://www.npmjs.com/package/tslint-react-redux-typescript-guide
Planned work:

  • updated tslint.json config to most recent TS version (add new strict options)
  • create and publish 1.0.0 release to npm registry
  • reference the package in the playground project

@piotrwitek piotrwitek self-assigned this Sep 17, 2018
@arshadkazmi42
Copy link
Contributor

@piotrwitek There has not been any updates on this for a long time.
Is it available to grab? I can work on this.

@piotrwitek
Copy link
Owner

I have created two packages that are solving this issue:

  1. https://github.com/piotrwitek/tslint-react-redux-typescript-guide
    Contains only tslint config
  2. https://github.com/piotrwitek/react-redux-typescript-scripts
    Contains all the different tools config shared in the guide and I'm willing to add more tools and scripts in the future e.g. jest, babel, eslint, npm scripts etc.

They are already on npm so you can start using them now

@IssueHuntBot
Copy link

@piotrwitek has rewarded $189.70 to @piotrwitek. See it on IssueHunt

  • 💰 Total deposit: $271.00
  • 🎉 Repository reward(20%): $54.20
  • 🔧 Service fee(10%): $27.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants