Fix invalid ARDUINO_x macro name for ttgo watch board #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

maxgerhardt wants to merge 1 commit into platformio:develop from maxgerhardt:patch-1

Contributor

maxgerhardt commented Jan 11, 2021 •

edited

Loading

Macro name was invalid since there must never ever be a - in the name of a macro
Macro name was wrong because Arduino-ESP32 uses -DARDUINO_TWatch as can be seen in https://github.com/espressif/arduino-esp32/blob/2452c1fb539246e47a715b74a3ad25b8a7ebbec7/boards.txt#L4537-L4550 and https://github.com/espressif/arduino-esp32/blob/2452c1fb539246e47a715b74a3ad25b8a7ebbec7/platform.txt#L75

Fixes

<command-line>:0:10: warning: ISO C++11 requires whitespace after the macro name

warnings when compiling for this board.


          Fix invalid macro name

1. Macro name was invalid since there must never ever be a `-` in the name of a macro
2. Macro name was wrong because Arduino-ESP32 uses `-DARDUINO_TWatch` as can be seen in https://github.com/espressif/arduino-esp32/blob/2452c1fb539246e47a715b74a3ad25b8a7ebbec7/boards.txt#L4537-L4550 and https://github.com/espressif/arduino-esp32/blob/2452c1fb539246e47a715b74a3ad25b8a7ebbec7/platform.txt#L75

Member

valeros commented Jan 12, 2021

Thanks, duplicate #436 . The variant will be updated together with a new Arduino core release.

valeros closed this

Contributor Author

maxgerhardt commented Jan 12, 2021

Woopsie. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet