fix: backtick processing #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current source generation produces hex encoded backticks, resulting in invalid code. There seems to be no way to properly encode or escape them, as the final code is itself part of a backticked multi-lines string. Go does not allow nesting or escaping backticks. There's some proposals to address this issue: - golang/go#32190 - golang/go#32590 but look like nothing got accepted there yet. The current sources have been updated to use string concatenation instead of backticks, and the generator got updated to panic if it encounter any. This is not an ideal solution, as some sources may require the usage of backticks at some point, but it would probably require a deeper rework of the generation to fix it (maybe external files + go:embed ?)
|
cc @CollierCZ following up from platformsh/platformsh-docs#2796 |
CollierCZ
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current source generation produces hex encoded backticks, resulting in invalid code.
There seems to be no way to properly encode or escape them, as the final code is itself part of a backticked multi-lines string.
Go does not allow nesting or escaping backticks. There's some proposals to address this issue:
but look like nothing got accepted there yet.
The current sources have been updated to use string concatenation instead of backticks, and the generator got updated to panic if it encounter any.
This is not an ideal solution, as some sources may require the usage of backticks at some point, but it would probably require a deeper rework of the generation to fix it (maybe external files + go:embed ?)