Skip to content

Reference Guide for Cookieplone make commands #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: 6.0
Choose a base branch
from
Open

Reference Guide for Cookieplone make commands #1934

wants to merge 8 commits into from
+163 −0

Conversation

Manas-Kenge
Copy link
Contributor

@Manas-Kenge Manas-Kenge commented Apr 7, 2025 •
edited by github-actions bot
Loading

stevepiercy
stevepiercy requested changes Apr 13, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass.

@github-project-automation github-project-automation bot moved this from New to In Progress in Plone Documentation Apr 13, 2025
stevepiercy
stevepiercy requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. Just a few tweaks here and there. Let's start getting some more eyes on this to review.

stevepiercy
stevepiercy requested changes Apr 15, 2025
View reviewed changes
stevepiercy
stevepiercy approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! I'd still like another pair of eyes to make sure that the descriptions for the make commands from Cookieplone are in fact correct and complete.

@github-project-automation github-project-automation bot moved this from In Progress to Approved in Plone Documentation Apr 15, 2025
@stevepiercy stevepiercy mentioned this pull request Apr 16, 2025
Merged
@stevepiercy
Copy link
Contributor

We will need to update this PR, pending the outcome of plone/cookieplone-templates#214.

@Manas-Kenge
Copy link
Contributor Author

Sure, this PR also needs the remaining commands to be added. I will do that as well.

davisagli
davisagli approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't cover all the commands, but the information that's here looks accurate so far. Maybe okay to merge it and then add more in a new PR?

@stevepiercy
Copy link
Contributor

Thanks for the review @davisagli. I'll merge this now, and we can add more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

@ericof ericof Awaiting requested review from ericof

@acsr acsr Awaiting requested review from acsr

@sneridagh sneridagh Awaiting requested review from sneridagh

Assignees
No one assigned
Labels
None yet
Projects
Plone Documentation
Status: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Reference Guide with Cookieplone make commands and prompt reference
3 participants
@Manas-Kenge @stevepiercy @davisagli