Skip to content

Finish domain traces/charts #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 27, 2021
Merged

Finish domain traces/charts #250

merged 19 commits into from
Nov 27, 2021

Conversation

kMutagene
Copy link
Collaborator

@kMutagene kMutagene commented Nov 25, 2021

This PR adds all missing args to domain traces:

  • Pie
  • Funnelarea
  • Sunburst
  • Treemap
  • Parcoord
  • Parcats
  • Sankey
  • Table
  • Indicator
  • Icicle
  • adapt tests
  • adapt docs

This is the last PR of this type, when it is merged Plotly.NET is almost feature complete.

this PR will

close #169
close #168
close #203
close #204
close #205
close #192 , close #196 (as these are the last traces left not implementing the pattern)
close #155

@kMutagene kMutagene marked this pull request as ready for review November 27, 2021 10:28
@kMutagene kMutagene marked this pull request as draft November 27, 2021 12:07
@kMutagene kMutagene marked this pull request as ready for review November 27, 2021 12:07
@kMutagene kMutagene merged commit b34fd04 into dev Nov 27, 2021
@kMutagene kMutagene deleted the finish-domain branch April 29, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment