Async canvas component / IE11 compatibility #29
Conversation
- async in manifest
dash_canvas/package.json
Outdated
| "@babel/polyfill": "^7.6.0", | ||
| "@babel/preset-env": "^7.6.2", | ||
| "@babel/preset-react": "^7.0.0", | ||
| "@plotly/webpack-dash-dynamic-import": "^1.1.2", |
There was a problem hiding this comment.
the dash custom dynamic import plugin / also, updating the toolchain
dash_canvas/package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "build:js-dev": "webpack --mode development", | |||
| "build:js": "webpack --mode production", | |||
| "build:py": "node ./extract-meta.js src/lib/components > dash_canvas/metadata.json && copyfiles package.json dash_canvas && venv/bin/python -c \"import dash; dash.development.component_loader.generate_classes('dash_canvas', 'dash_canvas/metadata.json')\"", | |||
| "build:all": "npm run build:js & npm run build:js-dev & npm run build:py" | |||
| "build:all": "npm run build:js && npm run build:js-dev && npm run build:py" | |||
There was a problem hiding this comment.
& makes build:py at the same time as the build.. we want them in sequence
setup.py
Outdated
| @@ -19,6 +19,6 @@ | |||
| include_package_data=True, | |||
| license=package['license'], | |||
| description=package['description'] if 'description' in package else package_name, | |||
| install_requires=['dash', 'dash-html-components', 'scikit-image', 'Pillow', | |||
| install_requires=['dash>=1.6.0', 'dash-html-components', 'scikit-image', 'Pillow', | |||
There was a problem hiding this comment.
now needs a version of dash with async support
There was a problem hiding this comment.
Can we take html, dcc, and plotly out of this list since they all come in with dash?
| dash-daq | ||
| ipdb | ||
| percy | ||
| selenium | ||
| flake8 | ||
| pylint |
There was a problem hiding this comment.
most of these are now covered by dash's test environment
Co-Authored-By: alexcjohnson <[email protected]>
|
|
||
| DashCanvas.propTypes = { | ||
| /** | ||
| * The ID used to identify this component in Dash callbacks | ||
| */ | ||
| id: PropTypes.string, | ||
| id: PropTypes.string, |
There was a problem hiding this comment.
there seems to be a mishmash of whitespace characters in various files...
|
LGTM! @emmanuelle I'll let you give final approval, just in case there's anything unusual - derived props or environment requirements... or if you have comments on any of the build changes here. |
- update artifacts
Marc-Andre-Rivet
changed the title
|
just a few new comments #29 (comment) #29 (comment) and there are still |
- package-lock - artifacts
|
Here's the docs with the candidate version: https://github.com/plotly/dash-docs/pull/699 Percy diffs were all related to (1) version change, (2) new arrow button |
|
Thank you @Marc-Andre-Rivet it looks good to me! 💃 |
Followup to plotly/dash#973
Now related to plotly/dash#1006