Skip to content

Remove react and reactDOM from dependencies. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Remove react and reactDOM from dependencies. #41

merged 2 commits into from
Nov 16, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Nov 13, 2018

They are peerDependencies served by dash and included in the _js_dist of dash-renderer.

Closes #39

@nicolaskruchten
Copy link
Contributor

I think they do need to be in devDependencies tho no?

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Nov 13, 2018

I don't know, I don't need them when developing from pycharm, maybe it's different with other editors ? I mean I get a warning that it's not installed but I still get auto completion.

In dcc, they are only peerDependencies.

@valentijnnieman
Copy link

@T4rk1n We're fixing that in plotly/dash-core-components#373 though. They should be in devDependencies, since the Demo and unit tests are using React.

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Nov 13, 2018

@valentijnnieman Right

@bpostlethwaite
Copy link
Member

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Nov 16, 2018

@bpostlethwaite I moved react from peerDependencies to devDependencies.

@bpostlethwaite
Copy link
Member

🙈 apparently I have forgotten how to read a diff

💃

@T4rk1n T4rk1n merged commit 7d2d64f into master Nov 16, 2018
@T4rk1n T4rk1n deleted the react-peer branch November 16, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants