Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Build Dash 1.0.0 version of dash-core-components for R #574

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Jun 21, 2019

This PR proposes to update the dashCoreComponents package to v1.0.0.

This is a breaking change in Dash for R, and this library will also require v1.0.0 of dash due to externalized property types (#767).

@rpkyle rpkyle self-assigned this Jun 21, 2019
@alexcjohnson
Copy link
Collaborator

I've mostly seen .yml but this is a funny read https://stackoverflow.com/questions/21059124/is-it-yaml-or-yml?rq=1

not sure why the tests keep failing, looks unrelated to the changes. Might be something flaky in this afternoon's update... if it doesn't pass after a few more retries I can look at it Monday.

@rpkyle rpkyle requested a review from Marc-Andre-Rivet July 2, 2019 19:00
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎪 💃 🎪

@rpkyle rpkyle merged commit fface5b into master Jul 2, 2019
@rpkyle rpkyle deleted the 1.0.0-cran branch July 2, 2019 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants