Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Git hooks husky #777

Merged
merged 13 commits into from
Mar 14, 2020
Merged

Git hooks husky #777

merged 13 commits into from
Mar 14, 2020

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Mar 13, 2020

Companion to plotly/dash#1151

Husky
Husky is a JS package that automagically runs commands on git hooks. For this repo it will run the lint script and expect no errors before allowing a commit to go through.

For the hooks to be present, the developer will need to run npm ci or npm install locally when cloning the repo.

Also adds black.

@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review March 13, 2020 19:53
@Marc-Andre-Rivet Marc-Andre-Rivet added this to the Dash v1.10 milestone Mar 13, 2020
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, so much cleaner! 💃

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit f32a236 into dev Mar 14, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the git-hooks-husky branch March 14, 2020 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants