This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Plotly.js 1.55.1 #858
Merged
Plotly.js 1.55.1 #858
+139
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.55.1 just came out |
alexcjohnson
reviewed
Sep 3, 2020
| @@ -70,7 +70,7 @@ def display_page(pathname): | |||
| time.sleep(2) | |||
|
|
|||
| # callback is called twice when defined | |||
| self.assertEqual(call_count.value, 2) | |||
| self.assertEqual(call_count.value, 1) | |||
There was a problem hiding this comment.
What happened here? Is this related to plotly/dash#1385 ? We should fix the comments on these two changed lines once this is understood. Any chance this means plotly/dash#883 or plotly/dash#1049 has incidentally been resolved?
There was a problem hiding this comment.
@alexcjohnson Yes. This is caused by plotly/dash#1385.
- The initial callback gets added to the list of requested callbacks
- Before
await wait(0);resolves thedcc.Locationcomponent renders and triggers asetPropsbecause its props are not populated / misaligned with the current url (before, the callback would have been executing before the component rendered) - An additional callback is added to the list of requested callbacks
await wait(0);resolves- There are now two callbacks for
test-url.pathnameand the oldest one gets pruned
There was a problem hiding this comment.
I'm still seeing plotly/dash#1049 running what I think is the latest version of everything. Is it supposed to be resolved as of this merge?
There was a problem hiding this comment.
The boundaries of the problem have changed a little, as evidenced by this test, but it’s definitely not fixed.
alexcjohnson
approved these changes
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.