Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Dont clone figure.layout #905

Merged
merged 16 commits into from
Jan 15, 2021
Merged

Dont clone figure.layout #905

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0482abd
Dont clone figure.layout
almarklein Dec 14, 2020
ec7b6bc
include responsive
almarklein Dec 15, 2020
fc1d7a2
keep track of original values of overridden data
almarklein Dec 16, 2020
99b4411
add test for layout shapes
almarklein Dec 16, 2020
196ec85
fix test (and black)
almarklein Dec 16, 2020
c7338c1
flake
almarklein Dec 16, 2020
eb82ae1
lint fixes
alexcjohnson Dec 16, 2020
fcdd87d
improve how prev originals are handled
almarklein Dec 17, 2020
05ddff4
add test to verify that original layout params are maintained
almarklein Dec 18, 2020
9075fc3
get rid of sleep
almarklein Dec 18, 2020
630b7d7
Merge branch 'dev' into figure-state
emmanuelle Jan 12, 2021
27d93b3
standardize state usage in Graph
alexcjohnson Jan 15, 2021
582d281
number the tests in graph_varia
alexcjohnson Jan 15, 2021
271ce56
tweak new tests - usage and explicit graph height
alexcjohnson Jan 15, 2021
6c8490c
more extensive test of graph responsive changes
alexcjohnson Jan 15, 2021
3c3f61d
changelog for don't clone figure layout
alexcjohnson Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/fragments/Graph.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,11 @@ class PlotlyGraph extends Component {
if (!layout) {
return layout;
}

return mergeDeepRight(layout, this.getLayoutOverride(responsive));
let override = this.getLayoutOverride(responsive);
for (let key in override) {
layout[key] = override[key];
}
return layout; // not really a clone
}

getConfigOverride(responsive) {
Expand Down