Skip to content

Update react/react-dom to 16.13.0 and docgen to 5.3.0 [ref dash#1531] #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
"cytoscape-svg": "0.2.0",
"lodash": "^4.17.11",
"ramda": "^0.25.0",
"react": "15.4.2",
"react": "^16.13.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's better to fix it to 16.13.0 since that's what's done on plotly/dash-core-components. Not sure if it might break dash if react/react-dom are upgraded beyond that.

Suggested change
"react": "^16.13.1",
"react": "16.13.0",

"react-cytoscapejs": "1.2.1",
"react-dom": "15.4.2"
"react-dom": "^16.13.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Suggested change
"react-dom": "^16.13.1"
"react-dom": "16.13.0"

},
"devDependencies": {
"babel-core": "^6.26.3",
Expand All @@ -57,7 +57,7 @@
"eslint-plugin-import": "^2.12.0",
"eslint-plugin-react": "^7.9.1",
"npm": "^6.14.4",
"react-docgen": "^2.21.0",
"react-docgen": "^5.3.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if a ~ would be better than ^ here (I just learned the differences here)

"style-loader": "^0.21.0",
"webpack": "^4.20.2",
"webpack-cli": "^3.1.1",
Expand Down
Loading