Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

improve dash import test #169

Merged
merged 2 commits into from
Dec 10, 2020
Merged

improve dash import test #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c309f
improve dash import test
alexcjohnson Dec 10, 2020
6f3a51c
changelog for import bug fix
alexcjohnson Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [UNRELEASED]
### Fixed
- [#169](https://github.com/plotly/dash-html-components/pull/169) - part of fixing dash import bug https://github.com/plotly/dash/issues/1143

## [1.1.1] - 2020-09-03
-Dash.jl Julia component generation
- Dash.jl Julia component generation

## [1.1.0] - 2020-08-25
### Added
Expand Down
15 changes: 3 additions & 12 deletions dash_html_components_base/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,9 @@
__version__ = package['version']

# Module imports trigger a dash.development import, need to check this first
if not hasattr(_dash, 'development'):
print(
"Dash was not successfully imported. Make sure you don't have a file "
"named \n'dash.py' in your current directory.", file=_sys.stderr)
_sys.exit(1)

# Must update to dash>=0.22.0 to use this version of dash-html-components
if not hasattr(_dash.development.base_component, '_explicitize_args'):
print("Please update the `dash` module to >= 0.22.0 to use this "
"version of dash_html_components.\n"
"You are using version {:s}".format(_dash.version.__version__),
file=_sys.stderr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪 ❤️

if not hasattr(_dash, '__plotly_dash') and not hasattr(_dash, 'development'):
print("Dash was not successfully imported. Make sure you don't have a file "
"named \n'dash.py' in your current directory.", file=_sys.stderr)
_sys.exit(1)


Expand Down