This repository was archived by the owner on Jun 4, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 49
Move PropTypes from React package to prop-types #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g React 16) Update components to use prop-types Move react (and react-dom) to peerDependencies to support multiple versions (15.4+ and 16.0+) Add package-lock.json
This looks good to me! I'm adding some standard dash integration tests in a separate PR so once that's merged into master let's just rebase this PR off of master so that tests run |
OK. Just @ me when that's all set and I'll rebase. |
…g React 16) Update components to use prop-types Move react (and react-dom) to peerDependencies to support multiple versions (15.4+ and 16.0+) Add package-lock.json
@chriddyp should be good now. |
thanks @mjclawar ! I'll make a new release shortly |
@mjclawar |
Nice! Did the same update for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the
PropTypes
import fromreact
toprop-types
.Example:
is now
This will allow
dash-html-components
to support React 16+ by patching in different versions to thedash-renderer
by the Dash developer (for now).For example, in the application definition file:
Changes
package-lock.json