-
-
Notifications
You must be signed in to change notification settings - Fork 49
Fix python 3.7 build #85
Conversation
Fix looks good 💃 |
@rmarren1 I thought so too, guess it takes it from a cache. |
@@ -1,6 +1,6 @@ | |||
pandas | |||
selenium | |||
dash | |||
dash>=0.32.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new requirement for the non-dev package? If so should it be set in setup.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's a requirement for building the components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. I was seeing this failure https://circleci.com/gh/conda-forge/dash-html-components-feedstock/17?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link upstream for 0.13.3. SyntaxError for the call sig in Script.py. Thought this might be related. Should 0.13.3 build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tar for 0.13.3 will fail on python 3.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Built the components in 0.13.3 on fresh environment that pulled dash==0.25.1 on python 3.6 so the async bug is back for the build. Locked dash>=0.32.2 so it doesn't happen again.