Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Fix python 3.7 build #85

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Fix python 3.7 build #85

merged 3 commits into from
Dec 17, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Dec 17, 2018

Built the components in 0.13.3 on fresh environment that pulled dash==0.25.1 on python 3.6 so the async bug is back for the build. Locked dash>=0.32.2 so it doesn't happen again.

@rmarren1
Copy link
Contributor

Fix looks good 💃
I always thought leaving the bare module name would pull the most recent version when you run pip install -r dev-requirements, did that not work?

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Dec 17, 2018

@rmarren1 I thought so too, guess it takes it from a cache.

@T4rk1n T4rk1n merged commit ab1aaa4 into master Dec 17, 2018
@T4rk1n T4rk1n deleted the fix-build branch December 17, 2018 19:54
@@ -1,6 +1,6 @@
pandas
selenium
dash
dash>=0.32.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new requirement for the non-dev package? If so should it be set in setup.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's a requirement for building the components.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. I was seeing this failure https://circleci.com/gh/conda-forge/dash-html-components-feedstock/17?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link upstream for 0.13.3. SyntaxError for the call sig in Script.py. Thought this might be related. Should 0.13.3 build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tar for 0.13.3 will fail on python 3.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

moorepants added a commit to regro-cf-autotick-bot/dash-html-components-feedstock that referenced this pull request Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants