Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Remove events #89

Merged
merged 15 commits into from
Jan 15, 2019
Merged

Remove events #89

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
37febab
lint generate-components
alexcjohnson Jan 6, 2019
173510e
npm test shortcut
alexcjohnson Jan 10, 2019
2f873da
ensure element list is unique
alexcjohnson Jan 10, 2019
887846f
remove events from generate-components script
alexcjohnson Jan 10, 2019
599d98c
rebuild
alexcjohnson Jan 10, 2019
a2e145e
update changelog
alexcjohnson Jan 10, 2019
bdfbb5c
add PR number to changelog for :hocho: events
alexcjohnson Jan 10, 2019
eb3c4de
lint scripts dir
alexcjohnson Jan 11, 2019
82695c1
simplify ci command & include lint
alexcjohnson Jan 11, 2019
52b049d
set +e along with lint and test errors
alexcjohnson Jan 14, 2019
3ad1dd3
fix lint error only - still has test error
alexcjohnson Jan 14, 2019
2930061
remove set +e
alexcjohnson Jan 14, 2019
15d2891
set +e and +o pipefail - still failing test only, not lint
alexcjohnson Jan 14, 2019
e42be85
new approach: npm-run-all -> run-s
alexcjohnson Jan 14, 2019
f28aede
remove fake test error
alexcjohnson Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/generate-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function generatePropTypes(element, attributes) {
'fireEvent': PropTypes.func,

'dashEvents': PropTypes.oneOf(['click']),

'setProps': PropTypes.func
`
}
Expand Down Expand Up @@ -174,7 +174,7 @@ function generateComponents(list, attributes) {
function writeComponents(components, destination) {
console.log(`Writing ${Object.keys(components).length} component files to ${srcPath}.`);
let componentPath;
for (let Component in components) {
for (const Component in components) {
componentPath = path.join(destination, `${Component}.react.js`);
fs.writeFileSync(componentPath, components[Component]);
}
Expand All @@ -192,7 +192,7 @@ if (!listPath) {
const list = fs
.readFileSync(listPath, 'utf8')
.split('\n')
.filter(item => !!item);
.filter(item => Boolean(item));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, please add the npm run lint command to the CI Build step


// Get the mapping of attributes to elements
const attributes = JSON.parse(fs.readFileSync(attributesPath, 'utf-8'));
Expand Down