Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Update R dashHtmlComponents package to 0.13.5 #91

Merged
merged 8 commits into from
Jan 29, 2019
Merged

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Jan 18, 2019

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.13.5 of dash-html-components. This PR closes #74.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

@alexcjohnson
Copy link
Collaborator

I'm not an R user, so can't comment on the code there, but it all looks good - and seems there are no references to events 🎉

Can you drop the built python files from this PR, since all they do is revert the changes I made in #89 with the as-yet-unpublished changes I made to the python codegen code?

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The props order for python component shouldn't change.

@rpkyle rpkyle changed the title Update R dashHtmlComponents package to 0.13.6 Update R dashHtmlComponents package to 0.13.5 Jan 29, 2019
@rpkyle
Copy link
Contributor Author

rpkyle commented Jan 29, 2019

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rpkyle rpkyle merged commit 602addc into master Jan 29, 2019
@alexcjohnson alexcjohnson deleted the 0.13.6-issue34 branch January 29, 2019 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R version of HTML components
3 participants