Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Clientside Callbacks #143

Merged
merged 50 commits into from
Apr 8, 2019
Merged

Clientside Callbacks #143

Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
e2455d2
:truck: Move `updateRequestQueue` to the top of the function
chriddyp Mar 30, 2019
8edbc0d
:racehorse: clientside hook
chriddyp Mar 30, 2019
5b9934d
:pencil: examples
chriddyp Mar 30, 2019
cf888fd
:one: first clientside test
chriddyp Mar 30, 2019
b2037be
:package: temporarily install the dash clientside-2 branch to run tests
chriddyp Mar 30, 2019
cefc5a2
:wrench: add the `clientside tests to the `test:py` run
chriddyp Mar 30, 2019
a33d765
:package: create builds
chriddyp Mar 30, 2019
78f9bdc
:zap: rm sample assets as it fails the linting tests
chriddyp Mar 30, 2019
3394dfd
:rose: prettier
chriddyp Mar 30, 2019
707fca9
:package: new build
chriddyp Mar 30, 2019
42a2484
:see_no_evil: missing import
chriddyp Mar 30, 2019
7380b55
:link: test chained assertions
chriddyp Mar 30, 2019
77b965f
:hand: tell eslint to ignore clientside test js
chriddyp Mar 30, 2019
57d3f08
:boom: handle & test clientside functions that raise an error
chriddyp Mar 30, 2019
fb51d1f
:wrench: eslint ignore
chriddyp Mar 30, 2019
f8eb31a
:rose: prettier
chriddyp Mar 30, 2019
7482e41
:question: try combining tests into single file
chriddyp Mar 30, 2019
b942a18
:truck: move clientside update logic into a function
chriddyp Mar 30, 2019
d868fb1
:1234: handle multiple outputs clientside
chriddyp Mar 30, 2019
0032132
:white_check_mark: test multiple outputs
chriddyp Mar 30, 2019
a2cb0c7
:rose: prettier
chriddyp Mar 30, 2019
9548653
:see_no_evil: typo
chriddyp Mar 30, 2019
9cf8b05
:pencil: rename `client` to `clientside` everywhere
chriddyp Mar 30, 2019
2ff50f1
:factory: simple to change to trigger a new circle build
chriddyp Mar 30, 2019
f89975c
:pencil: :clock1: rename and handle & test promises
chriddyp Apr 6, 2019
0974e66
:golf: inputs are always defined
chriddyp Apr 6, 2019
e54e365
:see_no_evil: typos all day
chriddyp Apr 6, 2019
87b686e
:name_badge: everything in a namespace
chriddyp Apr 6, 2019
872a2b7
:rose: prettier
chriddyp Apr 6, 2019
0c6ebfc
:palm_tree:
chriddyp Apr 6, 2019
efdff7b
:airplane: forgot to export
chriddyp Apr 6, 2019
20d0168
:hamburger: sloppy copy pasting
chriddyp Apr 6, 2019
1a5bf70
:see_no_evil:
chriddyp Apr 6, 2019
6ebc26e
:pencil: CHANGELOG
chriddyp Apr 6, 2019
7811b5f
:book: `CLIENTSIDE_ERROR` constant
chriddyp Apr 6, 2019
fb4b1d7
:nut_and_bolt: `if ({})` is `true`
chriddyp Apr 6, 2019
c2a7c37
:clock1: treat promises like the other functions - don't break the app
chriddyp Apr 6, 2019
714d30f
:see_no_evil: another typo
chriddyp Apr 6, 2019
0065a80
:1234: no longer use `ramda` namespace in test
chriddyp Apr 6, 2019
28590e7
:hear_no_evil: i make this typo so frequently
chriddyp Apr 6, 2019
374493d
:hocho: unify the test methods
chriddyp Apr 6, 2019
e06cd88
:pencil: reformat clientside tests to use existing functions
chriddyp Apr 6, 2019
67b3a6a
:rose: i will never get prettier right on the first try
chriddyp Apr 6, 2019
86111aa
:shower: eslint
chriddyp Apr 6, 2019
7f8b9e7
:hocho: remove sample examples
chriddyp Apr 6, 2019
26a5d28
:zap: rm unncessary comment
chriddyp Apr 6, 2019
cfa00da
:package: new build
chriddyp Apr 6, 2019
ed2cc64
:package: new build
chriddyp Apr 6, 2019
dd862bb
:zap: simpler API check as according to https://github.com/plotly/das…
chriddyp Apr 8, 2019
149820e
:lock: clientside on master now
chriddyp Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
git clone [email protected]:plotly/dash-html-components.git
git clone [email protected]:plotly/dash-table.git
. venv/bin/activate
cd dash && git checkout clientside-2 && cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: You can also do add -b clientside-2 in the git clone command above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-⛔️ as this line will disappear when the companion PR merges... but we may benefit 🐎 from using a shallow clone git clone -depth=1 on CI, in which case -b <branch> may be the required method.

pip install -e ./dash --quiet
cd dash-core-components && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
cd dash-html-components && npm install --ignore-scripts && npm run build && pip install -e . && cd ..
Expand Down
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ dist

dash_renderer/**/*.min.js
dash_renderer/**/*.dev.js
tests/test_clientside/
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## Unreleased
### Added
- Added support for clientside callbacks [#143](https://github.com/plotly/dash-renderer/pull/143)

## [0.21.0] - 2019-03-25
### Changed
[#140](https://github.com/plotly/dash-renderer/pull/140)
Expand Down
Loading