Table style #193
Table style #193
Conversation
- style_table default nested props
| const tableStyle = this.tableStyle(style_table); | ||
| const tableStyle = R.mergeAll( | ||
| this.tableStyle(DEFAULT_STYLE, style_table) | ||
| ); |
There was a problem hiding this comment.
Table style is now a combination of the prop and some default style
| @@ -52,7 +52,7 @@ export const defaultProps = { | |||
| }, | |||
| navigation: 'page', | |||
|
|
|||
| content_style: 'fit', | |||
| content_style: 'grow', | |||
There was a problem hiding this comment.
Default is now 'grow' -- a lot of tests are updated below to conserve behavior
- clean up styling files
| @@ -167,12 +169,11 @@ | |||
| } | |||
|
|
|||
| .dash-spreadsheet-container { | |||
| .reset-css(); | |||
There was a problem hiding this comment.
Consolidating component.less into Table.less
|
@valentijnnieman Good remark. Actually I only updated the tests where the width was important (a few fixtures, all the Width.*.percy and some specific dropdown ones -- there's quite a few that are using the default behavior) -- that being said, I just realized that I changed the Width.percentages tests and those should not have changed. Will make 'grow' explicit on those so at least some tests are using the non-default, non-fit path. Those tests are also not leveraging the new style API fully. |
Fixes the pure styling issues from #150 (not the filter inputs)