Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

3.1 update dependencies #251

Merged
merged 2 commits into from
Nov 26, 2018
Merged

3.1 update dependencies #251

merged 2 commits into from
Nov 26, 2018

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Nov 22, 2018

Just basic maintenance work, updating deps and clean up

"react-select": "^1.2.1",
"sheetclip": "^0.3.0"
},
"dependencies": {},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple ways of looking at the meaning of deps and devDeps in the npm world -- but in the end this project only exposes a bundled file containing all that's needed and that can be seen as there being only dev dependencies as there is nothing that is required outside that bundle in the production environment / to use the package. This is the approach taken here.

"wait-on": "^3.2.0",
"webpack": "^4.26.0",
"webpack-cli": "^3.1.2",
"webpack-dev-server": "^3.1.10",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of minor and some major version updates.

"react": "16.6.3",
"react-docgen": "^2.21.0",
"react-dom": "16.6.3",
"react-select": "^1.2.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new version 2.1.2 of this but we can't update because of internal dependencies on this version's structure. See #250

Copy link
Contributor

@valentijnnieman valentijnnieman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit a002772 into master Nov 26, 2018
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 3.1-update-dependencies branch July 18, 2019 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants