-
-
Notifications
You must be signed in to change notification settings - Fork 73
Issue 342 - Add column type support for conditionals #343
Conversation
As mentioned by @alexcjohnson, style_data_conditional is missing |
I'll also use the occasion to add a few more visual tests for the existing conditionals. One thing that that might be of interest is the style resolution logic that's going on behind the scene. For example, a data cell will apply all matching static and conditional styles, overriding previously set values in this order static cell styles --> conditional cell styles --> static data cell styles --> conditional data cell styles Styles defined at a higher index in the conditional arrays have precedence over the styles defined before. static_cell The final result will be The same logic applies to header and filter cells and is located in:
The style merging priority is the same |
…-type-filtering # Conflicts: # src/dash-table/derived/style/index.ts # src/dash-table/derived/style/props.ts
- update static_data_conditional nested props
@alexcjohnson I think this is ready to be looked at again. Since last update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💃
hello, |
As part of epic #166 and follow up to type support #297.
Fixes #342
Adds type support for conditionals.