This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Ability to export data as csv / xlsx file #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚚 move tests under integration and adapt to dash.testing
⚗️ draft case
update test case for download
dash_table/index.html
Outdated
| <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react-dom.js'></script> | ||
|
|
||
| <!-- <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js'></script> | ||
| <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react-dom.js'></script> --> |
There was a problem hiding this comment.
You can remove the two commented versions of React at this point.
demo/index.html
Outdated
| @@ -5,11 +5,15 @@ | |||
| </head> | |||
| <body> | |||
| <div id='root'></div> | |||
| <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js'></script> | |||
| <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react-dom.js'></script> | |||
| <!-- <script src='https://cdnjs.cloudflare.com/ajax/libs/react/15.4.2/react.js'></script> | |||
| @@ -316,6 +316,8 @@ interface IDefaultProps { | |||
| css: IStylesheetRule[]; | |||
| data: Data; | |||
| editable: boolean; | |||
| export_format: 'csv' | 'xlsx'; | |||
| return wb; | ||
| } | ||
|
|
||
| export function createWorksheet(heading: string[][], data: any[], columnID: string[], exportHeader: string ) { |
There was a problem hiding this comment.
There is a Data type in tables/props.ts - sheet_add_json expects any[] but both types should be compatible as Data is resolved as (IDatumObject | any)[]
Marc-Andre-Rivet
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #313