This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Fix Percy Storybook Usage #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Andre-Rivet
commented
Jan 6, 2020
| @@ -1,6 +1,9 @@ | |||
| let babel = require('./babel.config.js'); | |||
| let config = require('./../.config/webpack/base.js')({ | |||
| babel, | |||
| ts: { | |||
| transpileOnly: true | |||
| }, | |||
There was a problem hiding this comment.
@storybook/react now uses a library called emotions which does processing on all css component props expected type def in TypeScript. We use typescript, it trips us up. Removing type checking for tests like already done in Cypress.
Marc-Andre-Rivet
commented
Jan 6, 2020
| @@ -270,7 +270,7 @@ storiesOf('DashTable/Sorting', module) | |||
| sort_as_null={['']} | |||
| style_data_conditional={style_data_conditional} | |||
| />)) | |||
| .add(`"a" descending -- '' & 426 override`, () => (<DataTable | |||
| .add(`"a" descending -- empty string & 426 override`, () => (<DataTable | |||
There was a problem hiding this comment.
Not using '' makes the test display content again.
Marc-Andre-Rivet
commented
Jan 6, 2020
| @@ -147,7 +147,8 @@ jobs: | |||
| - run: | |||
| name: Run visual tests | |||
| command: npm run test.visual | |||
|
|
|||
| - store_artifacts: | |||
| path: storybook-static | |||
There was a problem hiding this comment.
To help figure out what's potentially wrong with visual tests, store the storybook generation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the latest Percy update caused problems with
'in names. Mix of many things that were attempted and that in the end provide value whether they fix something or not: temporarily fix the percy storybook tests, updates the toolchain, outputs storybook artifacts in CI.