-
-
Notifications
You must be signed in to change notification settings - Fork 73
Issue 660 - Increase page_current
and page_count
fields size to accommodate larger numbers
#819
Conversation
page_current
and page_count
fields size to accommodate larger numbers
&:focus { | ||
outline: none; | ||
border: none; | ||
width: 7ch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1ch
is the space required to display a 0
- since there's some padding/margins 7ch displays 6 chars for sure, maybe 7 depending on the font-size, etc.
page_action='custom' | ||
page_count={999999} | ||
page_current={987654} | ||
page_size={10} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple visual test to see that numbers with 6 digits are displayed correctly.
This seems reasonable, but I wonder if these need to be fixed widths? Is it problematic to let them grow with their content? |
Inputs are weird beast and can't typically made to automatically grow with content, unlike other elements. Typically this can be worked around by using something like |
Ah right, number validation and other bits of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 💃
Closes #660
page_current
andpage_count
fields based on the number of pages (1ch/char + 1)page_current
field for the case where nopage_count
is defined (e.g.page_action='custom'
without the server returningpage_count