Merge pull request #2474 from plotly/fix-2220

Fix some build errors not failing build.

Author: T4rk1n

Diff for: components/dash-core-components/package.json

@@ -15,7 +15,7 @@
     "private::format.black": "black dash_core_components_base/ tests/ setup.py",
     "private::format.eslint": "eslint src --fix",
     "private::format.prettier": "prettier --config .prettierrc --write src/**/*.js",
-    "private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black --check dash_core_components_base/ tests/ setup.py; fi",
+    "private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python39') !== 'python36'){process.exit(1)} \" || black --check dash_core_components_base/ tests/ setup.py",
     "private::lint.eslint": "eslint src",
     "private::lint.flake8": "flake8 --exclude=dash_core_components,node_modules,venv",
     "private::lint.prettier": "prettier --config .prettierrc src/**/*.js --list-different",

Diff for: components/dash-html-components/scripts/extract-elements.js

@@ -61,7 +61,8 @@ function extractElements($) {
 
 request(refUrl, (error, response, html) => {
     if (error) {
-        throw error;
+        console.error(error);
+        process.exit(-1);
     }
     const $ = cheerio.load(html);
     const elements = extractElements($);
@@ -79,11 +80,12 @@ request(refUrl, (error, response, html) => {
         catch(e) {
             console.log('no previous elements found');
         }
-        throw new Error(
+        console.error(
             'Unexpected number of elements extracted from ' + refUrl +
             ' - Found ' + elements.length + ' but expected ' + expectedElCount +
             ' Check the output and edit expectedElCount if this is intended.'
         );
+        process.exit(-1);
     }
     const out = elements.join('\n');
 

Diff for: components/dash-table/package.json

@@ -23,7 +23,7 @@
     "private::format.black": "black dash_table_base tests",
     "private::lint.ts": "eslint ./src ./tests",
     "private::lint.flake": "flake8 dash_table_base tests",
-    "private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black --check dash_table_base tests; fi",
+    "private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python39') !== 'python36'){process.exit(1)} \" || black --check dash_table_base tests",
     "private::lint.prettier": "prettier --config .prettierrc \"{src,tests,demo}/**/*.{js,ts,tsx}\" --list-different",
     "private::test.python": "python -m unittest tests/unit/format_test.py",
     "private::test.unit": "karma start karma.conf.js --single-run",

Diff for: package.json

@@ -10,7 +10,7 @@
     "private::build.components": "python dash/development/update_components.py 'all'",
     "private::cibuild.renderer": "cd dash/dash-renderer && renderer build",
     "private::build.renderer": "cd dash/dash-renderer && renderer build",
-    "private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black dash tests --exclude metadata_test.py --check; fi",
+    "private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python39') !== 'python36'){process.exit(1)} \" || black dash tests --exclude metadata_test.py --check",
     "private::lint.flake8": "flake8 --exclude=metadata_test.py dash tests",
     "private::lint.pylint-dash": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint dash setup.py --rcfile=$PYLINTRC",
     "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",