Skip to content

Fix some build errors not failing build. #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2023
Merged

Fix some build errors not failing build. #2474

merged 5 commits into from
Apr 21, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Mar 21, 2023

Fix #2220

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner March 21, 2023 19:58
@T4rk1n

This comment was marked as outdated.

Sign in to view
alexcjohnson
alexcjohnson approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks - shell scripts are always confusing, this looks like a nice way to ensure it's cross-platform and robust.

@T4rk1n T4rk1n merged commit b61cb82 into dev Apr 21, 2023
@T4rk1n T4rk1n deleted the fix-2220 branch April 21, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CI swallowing some errors
2 participants
@T4rk1n @alexcjohnson