-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Dash 3.0 feedback #3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
No
I noticed that one and fixed it in #3141 for RC2
There is no
Yes this can be added later in a 3.1 or later, probably best to think about the API properly as I think it could also be used to render components from clientside callbacks. |
I was testing things out for dmc, dash 3 and dag. I ran into an issue when trying to load custom components into the grid. This issue happened with both dmc and dash components trying to display in the grid. I believe if you were to provide a response for the |
It would be helpful to have a better error message that included how to fix it (ie "use
|
I think this is because the context is not found, by creating the component without the DashWrapper. I'll add a warning and return {}, then you can use |
Another thing that I've noticed, when importing |
Thanks fixed in #3164 |
Would it be possible to add something like this, where we can run one function to populate components in dash?
^ the above code was adjusted from @emilhe Additionally, could you expose |
👍 👍 Two thumbs up for adding the Exposing the |
I added in #3175 for RC3
Thanks for the feedback. |
Any thoughts on the renderDashComponent(s)? Or just keep it as something people have to add-on? |
Hey @T4rk1n, For the Please also make it so that we can simply do this:
|
@marthacryan please have a look at the dark mode issue that @AnnMarieW reported - thanks. |
@AnnMarieW w.r.t. minimizing space, we found that it was difficult to clearly convey information with the closed dev tools UI (new update notification) while minimized so went with the default open. However we also explored a pattern where it would be full-width on the footer but not overlay on top of the app, ensuring no app real estate would be covered. We've had feedback from a couple people that it takes up too much space as-is, though. Here is a comparison of a few different patterns: With ability to minimizeFull widthThis appears to be floating in the mock but it would not be a floating footer when implemented I'm hesitant to make significant UI changes at this point in the dev process to avoid delaying 3.0 further but would love your feedback regardless: We could switch to e.g. the full footer mode in 3.1. |
I think if full, you should make it a real footer instead of overlaying the app, this way you can at least scroll to things that would be hidden if needed... As far as minimized view, I vote num 3 |
@BSd3v yes, it'd be a real footer, no overlay. To be clear from a design perspective internally we lean footer over any of the minimized options. We also prefer the always-expanded option to any of the minimized options. |
@ndrezn I also really like that the version number is included—it will be very helpful for debugging and especially useful when assisting people who are new to Dash. |
@T4rk1n
|
It's the ReactMarkdown component from the library, we use a really old version of react-markdown and the newer versions has changed the API as such it doesn't work. We will need to update the package before react 18. |
Can we do that update as part of the 3.0 release or should we leave it for 3.1? |
It should be included but we need to make sure it works with highlighting and mathjax. Also maybe test on the docs since that is used in example. |
Running into an issue when trying to perform them in dash 3rc3:
dash=3.0.0rc3 |
In dash==3.0.0rc3 I can't seem to select the top option in a from dash import Dash, Input, Output, dcc, html
app = Dash(__name__)
app.layout = html.Div(
[
dcc.Dropdown(
id="dropdown",
options=[
{"label": city, "value": city}
for city in ["New York City", "Montréal", "San Francisco"]
],
value="New York City",
),
html.Div(id="output"),
]
)
@app.callback(Output("output", "children"), [Input("dropdown", "value")])
def callback(value):
return f"You have selected {value}"
if __name__ == "__main__":
app.run(debug=True) |
To narrow it down - you can't select whatever is set initially in the |
Fixed in rc4 |
@T4rk1n please file separate issues for the pieces of this that are still unsolved and then close this one - thank you. |
thank you @T4rk1n |
Can we get the changes to the dev UI as an issue too? Right now... its just so much room at the bottom and interferes with notifications. Or is someone already working on this adjustment? |
@BSd3v please go ahead and file that one and tag me - thanks |
Thanks for making the dash 3.0 pre-release available. 🎉
Just a couple questions and comments:
Are you still planning on removing the
_timestamp
props? remove_timestamp
properties #3055The
dcc.Dropdown
is still usingdefaultProps
which is causing a warning in the console. There are other console warning withdcc.Dropdown
, but those aren't new, just wondering if there are plans to fix those too.In
dcc.Loading
, thecustom_component
shows a typehints warning if you use components other thanhtml
components.Feature request:
renderDashComponents
from the dash-extensions.js library to render components as props defined inchildren
. For more details see: Improve performance of context components re-rendering #3066 (comment). Philippe mentioned he could add arender(component, path)
todash_component_api
quite easily, but wanted to wait for another release.The text was updated successfully, but these errors were encountered: