Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_configs file is missing docstrings #3194

Open
JinHuang0101 opened this issue Feb 26, 2025 · 4 comments
Open

test_configs file is missing docstrings #3194

JinHuang0101 opened this issue Feb 26, 2025 · 4 comments
Labels
feature something new P2 considered for next cycle

Comments

@JinHuang0101
Copy link

All methods in the test_configs.py file are missing docstrings and in-line comments. Adding docstrings and inline comments to the file will help contributors quickly understand and build upon the test code.
@JinHuang0101
Copy link
Author

I'd love to work on this issue and complete the documentation for this file.

@gvwilson
Copy link
Contributor

thanks @JinHuang0101 - if you would like to prepare a PR we would be happy to prioritize review.

@gvwilson gvwilson changed the title [Documentation]Add missing docstrings to test_configs file test_configs file is missing docstrings Feb 28, 2025
@gvwilson gvwilson added feature something new P2 considered for next cycle labels Feb 28, 2025
@JinHuang0101
Copy link
Author

thanks @JinHuang0101 - if you would like to prepare a PR we would be happy to prioritize review.

Thank you! Will do.

This was referenced Mar 10, 2025
Closed
Closed
JinHuang0101 added a commit to JinHuang0101/dash that referenced this issue Mar 10, 2025
@JinHuang0101
Added missing docstrings to test_configs file plotly#3194
42f6a07
@JinHuang0101 JinHuang0101 mentioned this issue Mar 10, 2025
Open
9 tasks
@JinHuang0101
Copy link
Author

thanks @JinHuang0101 - if you would like to prepare a PR we would be happy to prioritize review.

Hi @gvwilson ,
My PR was created here #3205
The only test that I failed was [lint-unit-312]. I only changed the test_configs file and I didn't change any other config like the advanced typescript version reported in the error message.
Let me know how I can further debug this.
Thanks!
Jin

JinHuang0101 added a commit to JinHuang0101/dash that referenced this issue Mar 19, 2025
@JinHuang0101
Update:Added details to docstrings.Added missing docstrings to test_c…
1db3990 
…onfigs file plotly#3194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature something new P2 considered for next cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvwilson @JinHuang0101