Update Dash dependencies #1367
Update Dash dependencies #1367
Conversation
| @@ -104,7 +104,7 @@ jobs: | |||
| command: | | |||
| . venv/bin/activate && pip install --no-cache-dir --upgrade -e . --progress-bar off && mkdir packages | |||
| cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd .. | |||
| git clone --depth 1 https://github.com/plotly/dash-core-components.git | |||
| git clone -b 20200814-update-deps --depth 1 https://github.com/plotly/dash-core-components.git | |||
There was a problem hiding this comment.
Run against the modified branches of Core components
| @@ -70,6 +70,7 @@ disable=invalid-name, | |||
| long-suffix, | |||
| old-ne-operator, | |||
| old-octal-literal, | |||
| import-outside-toplevel, | |||
There was a problem hiding this comment.
Was previously ignored
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "tabWidth": 4, | |||
| "singleQuote": true, | |||
| "arrowParens": "avoid", | |||
There was a problem hiding this comment.
Default changed
dash-renderer/package.json
Outdated
| "private::format.ts": "tslint --fix --project tsconfig.json --config tslint.json", | ||
| "private::lint.js-eslint": "eslint .", | ||
| "private::lint.js-prettier": "prettier --config .prettierrc \"src/**/*.js\" --list-different", | ||
| "private::lint.js-prettier": "prettier --config .prettierrc \"src/**/*.(js|ts|tsx)\" --list-different", |
There was a problem hiding this comment.
Apply Prettier to TypeScript files too.
@alexcjohnson Since you've mentioned it before. Might as well.. makes little sense to do one extension and not the other.
| @@ -1,14 +1,14 @@ | |||
| dash_flow_example==0.0.5 | |||
| dash-dangerously-set-inner-html | |||
| isort==4.3.21 | |||
There was a problem hiding this comment.
isort can't be upgraded, hard dep on 4.x
| pylint==1.9.4;python_version<"3.7" | ||
| pylint==2.3.1;python_version=="3.7" | ||
| astroid==2.2.5;python_version=="3.7" | ||
| pylint==2.5.3;python_version=="3.7" |
There was a problem hiding this comment.
Updating pylint and flake8 has side-effects on other core/ancillary component libraries.
|
@Marc-Andre-Rivet this looks stale - anything you want to resurrect from this PR or shall I just close it? |
|
There are a number of updates here that haven't been handled elsewhere, but after #1611 I think it'll be easier to remake from scratch than to drag this PR forward. |
No description provided.