Skip to content

use plotly.js-dist-min in webpack externals #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2022
Merged

use plotly.js-dist-min in webpack externals #1929

merged 2 commits into from
Feb 16, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 15, 2022

Follow up of #1911.
Now that plotly.js-dist-min is the name of the package used instead of plotly.js.
@alexcjohnson

@alexcjohnson
Copy link
Collaborator

Can we just delete those? html and table shouldn't use plotly.js at all, right?

@archmoj
Copy link
Contributor Author

archmoj commented Feb 15, 2022

Can we just delete those? html and table shouldn't use plotly.js at all, right?

Good call. Looks like we could. Removed in 0a8cf57.

alexcjohnson
alexcjohnson approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit fb34b52 into dev Feb 16, 2022
@alexcjohnson alexcjohnson deleted the more-plotly.js-dist-min branch February 16, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson