Skip to content

Fix empty headerOpEdges. #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022
+24 −0
Merged

Fix empty headerOpEdges. #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc736cb
Fix empty headerOpEdges.
nickmelnikov82 Apr 14, 2022
d9c8760
Merge branch 'dev' into fix-factory-empty-props
nickmelnikov82 Apr 19, 2022
9100c7c
Added changelog entry.
nickmelnikov82 Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## [Unreleased]

### Fixed

- [#2015](https://github.com/plotly/dash/pull/2015) Fix bug [#1854](https://github.com/plotly/dash/issues/1854) in which the combination of row_selectable="single or multi" and filter_action="native" caused the JS error.

### Changed

- [#2016](https://github.com/plotly/dash/pull/2016) Drop the 375px width from default percy_snapshot calls, keep only 1280px
Expand Down
4 changes: 4 additions & 0 deletions components/dash-table/src/dash-table/components/EdgeFactory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ export default class EdgeFactory {
const iNext = 0;
const iTarget = hTarget.rows - 1;

if (!isFinite(iTarget)) {
return;
}

R.forEach(
j =>
!EdgeFactory.hasPrecedence(
Expand Down
16 changes: 16 additions & 0 deletions components/dash-table/tests/selenium/test_basic_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,3 +426,19 @@ def test_tbst023_sorted_table_delete_multiple_cells_while_selected(test, props):
assert target.cell(row, col).get_text() == ""

assert test.get_log_errors() == []


def test_tbst024_row_selectable_filter_action(test):
app = dash.Dash(__name__)

app.layout = DataTable(
id="test-table",
row_selectable="single",
filter_action="native",
)

test.start_server(app)

test.wait_for_element("#test-table")

assert test.get_log_errors() == []